Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common conditionals for reactive implementation #1514

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Nov 18, 2023

No description provided.

@wind57 wind57 changed the title Align fabric8 k8s discovery clients part 11 common conditionals for reactive implementation Nov 18, 2023
@ConditionalOnKubernetesDiscoveryEnabled
@ConditionalOnReactiveDiscoveryEnabled
@ConditionalOnCloudPlatform(CloudPlatform.KUBERNETES)
public @interface ConditionalOnSpringCloudKubernetesReactiveDiscovery {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we just did this work for blocking discovery, now for reactive. Nothing else changes in this PR

@wind57 wind57 marked this pull request as ready for review November 21, 2023 07:32
@wind57
Copy link
Contributor Author

wind57 commented Nov 21, 2023

@ryanjbaxter we did blocking yesterday, same thing for reactive today. thank you

@ryanjbaxter ryanjbaxter added this to the 3.0.6 milestone Nov 21, 2023
@ryanjbaxter ryanjbaxter merged commit 0c149f8 into spring-cloud:3.0.x Nov 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants