Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor fabric8 discovery integration tests (2) #1756

Merged
merged 41 commits into from
Dec 3, 2024

Conversation

wind57
Copy link
Contributor

@wind57 wind57 commented Oct 7, 2024

No description provided.

@wind57 wind57 changed the title Refactor integration tests 2 Refactor fabric8 discovery integration tests Oct 7, 2024
@wind57 wind57 changed the title Refactor fabric8 discovery integration tests Refactor fabric8 discovery integration tests (2) Oct 9, 2024
@wind57
Copy link
Contributor Author

wind57 commented Nov 29, 2024

The idea of refactoring tests in this manner was talked with you here: #1755

This is a continuation of the same process, but I had to take a detour because other issues more important appeared. But now Im back to these... Logically the same exact same assertions are in place, nothing changed in that regard.

running time as-is, before this refactoring:

________________________________________________________
Executed in  260.82 secs    fish           external
   usr time   16.80 secs   94.00 micros   16.80 secs
   sys time    4.88 secs  673.00 micros    4.88 secs

after the refactoring:

________________________________________________________
Executed in  182.00 secs    fish           external
   usr time   27.18 secs   92.00 micros   27.18 secs
   sys time    5.55 secs  896.00 micros    5.55 secs

around 1.5 minutes saved.

@wind57 wind57 marked this pull request as ready for review November 29, 2024 14:52
@wind57
Copy link
Contributor Author

wind57 commented Nov 29, 2024

@ryanjbaxter this one is ready too. thank you

@ryanjbaxter ryanjbaxter added this to the 3.1.5 milestone Dec 3, 2024
@ryanjbaxter ryanjbaxter merged commit d29c69b into spring-cloud:3.1.x Dec 3, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants