Simplify CI-PR #567
Merged
Simplify CI-PR #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onobc
reviewed
Nov 8, 2024
.github/workflows/ci-pr.yml
Outdated
| @@ -135,9 +66,23 @@ jobs: | |||
| - name: 'Built' | |||
| shell: bash | |||
| run: echo "::info ::Built" | |||
| scan: | |||
There was a problem hiding this comment.
Let's remove this scan from the PR build as we do not accept dep. updates in PRs and Trivy is failing 99% of the time due to its rate limiting.
onobc
reviewed
Nov 8, 2024
.github/workflows/ci-pr.yml
Outdated
| java-version: '17' | ||
| components: 'js' | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| java-version: '17.0.12' |
There was a problem hiding this comment.
Any particular reason so specific w/ patch version?
There was a problem hiding this comment.
setup-java@v4 requires complete version for some reason it doesn't select latest when you only specify 17
corneil
force-pushed
the
corneil/simplify-ci-pr
branch
from
733e743
to
88f5e43
Compare
Removed checks for changed modules and ensure the build scripts works in the absence of credentials. See spring-cloud#550
corneil
force-pushed
the
corneil/simplify-ci-pr
branch
from
c76a02b
to
aaf8f47
Compare
Removed checks for changed modules and ensure the build scripts works in the absence of credentials. See spring-cloud#550
Removed checks for changed modules and ensure the build scripts works in the absence of credentials. See spring-cloud#550
Removed checks for changed modules and ensure the build scripts works in the absence of credentials. See spring-cloud#550
Removed checks for changed modules and ensure the build scripts works in the absence of credentials. See spring-cloud#550
This changes the distribution to use liberica since it properly detects the latest patch version of the distribution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed checks for changed modules and ensure the build scripts works in the absence of credentials.
See #550