spring-boot: install CLI jars into libexec and wrap binary #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move the Spring Boot CLI jars from lib/ to libexec and create a wrapper script in bin. This removes the Homebrew warning shown when installing with HOMEBREW_DEVELOPER=true. The formula now follows the recommended pattern used by other Java formulae (e.g. activemq, jruby). Also adjusted completion installation to avoid "empty array" warnings when completion scripts are not present in the distribution tarball. Signed-off-by: lublanski <[email protected]>
Lublanski
force-pushed
the
fix/spring-boot-libexec
branch
from
5e7f7bd to
a127063
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the
spring-boot.rbformula to install CLI jars intolibexecinstead oflib, and creates a wrapper script inbin/spring.Motivation
Installing JARs to
libis discouraged by Homebrew since it can cause conflicts between packages.The recommended approach is to use
libexecand symlink or wrap binaries intobin.This change removes the following warning when installing with
HOMEBREW_DEVELOPER=true:Additionally, the completion installation was adjusted to avoid spurious warnings when completion scripts are not present in the distribution tarball.
Related Issue
Fixes spring-projects/spring-boot#46866
How to test
brew install --build-from-source spring-boot.rbwithHOMEBREW_DEVELOPER=true.spring --versionshould print the CLI version correctly.