fix: Sass warnings

spring-io · Dec 3, 2024 · f652cb5 · f652cb5
1 parent 5245302
commit f652cb5
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 21 deletions.
diff --git a/start-client/src/styles/_main.scss b/start-client/src/styles/_main.scss
@@ -98,9 +98,9 @@ body {
     cursor: pointer;
     width: $size + 12px;
     height: $size + 12px;
-    @include transition(color $spring-transition-duration);
     border: 0 none;
     background: none;
+    @include transition(color $spring-transition-duration);
     .icon-history {
       width: 30px;
       margin-top: 6px;
@@ -148,11 +148,11 @@ body {
   h1.logo {
     max-width: 320px;
     padding: 2rem 0;
+    display: block;
     a {
-      @include outline;
-      display: block;
       margin-left: -6px;
       color: $light-color;
+      @include outline;
       .logo-content {
         display: block;
         outline: none;
@@ -253,8 +253,6 @@ hr.divider {
       padding-right: 1rem;
     }
   }
-  .right {
-  }
 }
 
 .col-sticky {
@@ -428,10 +426,10 @@ button.button {
   margin-right: 1rem;
   cursor: pointer;
   background: transparent;
-  @include transition(all calc($spring-transition-duration / 2));
   z-index: 1;
   background: $light-background;
   font-family: $spring-font-family;
+  @include transition(all calc($spring-transition-duration / 2));
   &:focus {
     outline: none;
     box-shadow: 0 0 0 4px $light-border;
@@ -463,8 +461,8 @@ button.button {
     bottom: 0;
     width: 100%;
     opacity: 0;
-    @include transition(all calc($spring-transition-duration / 2));
     z-index: -1;
+    @include transition(all calc($spring-transition-duration / 2));
   }
   &:hover,
   &:disabled {

diff --git a/start-client/src/styles/_mixins.scss b/start-client/src/styles/_mixins.scss
@@ -1,21 +1,17 @@
 @mixin transition($args...) {
-  -webkit-transition: $args;
-  -moz-transition: $args;
-  -ms-transition: $args;
-  -o-transition: $args;
-  transition: $args;
-}
-
-@mixin clearfix {
-  &:after {
-    content: '';
-    display: table;
-    clear: both;
+  & {
+    -webkit-transition: $args;
+    -moz-transition: $args;
+    -ms-transition: $args;
+    -o-transition: $args;
+    transition: $args;
   }
 }
 
 @mixin outline {
-  outline: 1px dotted transparent;
+  & {
+    outline: 1px dotted transparent;
+  }
   &:focus {
     outline: 1px dotted $light-outline;
     // outline: none;

diff --git a/start-client/src/styles/explore.scss b/start-client/src/styles/explore.scss
@@ -225,6 +225,7 @@
     color: $light-color;
     word-wrap: normal;
     white-space: nowrap;
+    outline: 1px dotted transparent;
     .item-content {
       box-shadow: none;
       outline: none;
@@ -256,7 +257,6 @@
       width: 16px;
     }
 
-    outline: 1px dotted transparent;
     &:focus {
       outline: 1px dotted darken($light-background-seconday, 10);
     }