Proposed resolution of issue #157 and #149 #173
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…orrecting previously present 'Warnings'.
joaobertholino
changed the title
joaobertholino
changed the title
joaobertholino
changed the title
arey
reviewed
Nov 19, 2024
| @@ -18,6 +20,7 @@ public interface OwnerMapper { | |||
|
|
|||
| Owner toOwner(OwnerDto ownerDto); | |||
|
|
|||
| @Mappings(value = {@Mapping(target = "id", ignore = true), @Mapping(target = "pets", ignore = true)}) | |||
There was a problem hiding this comment.
suggestion: we could avoid the @Mappings annotation
See https://mapstruct.org/documentation/stable/reference/html/#basic-mappings
arey
reviewed
Nov 19, 2024
| public ErrorInfo(Exception ex) { | ||
| this(ex.getClass().getName(), ex.getLocalizedMessage()); | ||
| } | ||
| private ProblemDetail detailBuild(Exception ex, HttpStatus status) { |
There was a problem hiding this comment.
suggestion: could you please split your Pull Request into 2 PR?
This was referenced Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing warnings regarding class mappings with Map Struct as per Pull Request #168 and from issue #157.
Implemented the use of ProblemDetail in error responses according to issue #149.