Cassandra Chat Memory: Fixed message order #2839
Conversation
Signed-off-by: Linar Abzaltdinov <[email protected]>
Signed-off-by: Linar Abzaltdinov <[email protected]>
…ontainer by actual one Signed-off-by: Linar Abzaltdinov <[email protected]>
|
@michaelsembwever @tzolov As main contributor/reviewer of CassandraChatMemory feature, could you please take a look at this PR? |
|
|
||
| import java.time.Duration; | ||
| import java.util.List; | ||
| import java.util.UUID; |
There was a problem hiding this comment.
is it correct to move import java… down to here ?
There was a problem hiding this comment.
Well, that's how Intellij IDEA orders imports by default.
Didn't know about code style guide of Spring projects.
Reordered as it described in https://github.com/spring-projects/spring-framework/wiki/Code-Style
Signed-off-by: Linar Abzaltdinov <[email protected]>
|
@linarkou thanks so much for your contribution! I'd like to reference here the comment I left on the similar PR for JDBC about the new APIs and changes we have just delivered for chat memory: #2781 (comment) |
…-fix-message-order
|
I would implement |
Fixes issue #2815
This PR solves problem with message ordering:
CassandraChatMemory fetches rows in DESC order (by message_timestamp), and MessageChatMemoryAdvisor get and add all messages in that order - from last to first. So messages list needs to be reversed.
Same problem of JDBC Chat Memory solved here #2781