Skip to content

Add OpenAI's Image edit feature #2914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,81 @@
/*
* Copyright 2023-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.ai.model.openai.autoconfigure;

import static org.springframework.ai.model.openai.autoconfigure.OpenAIAutoConfigurationUtil.resolveConnectionProperties;

import org.springframework.ai.image.observation.ImageModelObservationConvention;
import org.springframework.ai.model.SimpleApiKey;
import org.springframework.ai.model.SpringAIModelProperties;
import org.springframework.ai.model.SpringAIModels;
import org.springframework.ai.openai.OpenAiImageEditModel;
import org.springframework.ai.openai.OpenAiImageModel;
import org.springframework.ai.openai.api.OpenAiApi;
import org.springframework.ai.openai.api.OpenAiImageApi;
import org.springframework.ai.retry.autoconfigure.SpringAiRetryAutoConfiguration;
import org.springframework.beans.factory.ObjectProvider;
import org.springframework.boot.autoconfigure.AutoConfiguration;
import org.springframework.boot.autoconfigure.ImportAutoConfiguration;
import org.springframework.boot.autoconfigure.condition.ConditionalOnClass;
import org.springframework.boot.autoconfigure.condition.ConditionalOnMissingBean;
import org.springframework.boot.autoconfigure.condition.ConditionalOnProperty;
import org.springframework.boot.autoconfigure.web.client.RestClientAutoConfiguration;
import org.springframework.boot.autoconfigure.web.reactive.function.client.WebClientAutoConfiguration;
import org.springframework.boot.context.properties.EnableConfigurationProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.retry.support.RetryTemplate;
import org.springframework.web.client.ResponseErrorHandler;
import org.springframework.web.client.RestClient;

import io.micrometer.observation.ObservationRegistry;

/**
* Image {@link AutoConfiguration Auto-configuration} for OpenAI.
*
* @author Minsoo Nam
*/
@AutoConfiguration(after = { RestClientAutoConfiguration.class, WebClientAutoConfiguration.class,
SpringAiRetryAutoConfiguration.class })
@ConditionalOnClass(OpenAiApi.class)
@ConditionalOnProperty(name = SpringAIModelProperties.IMAGE_EDIT_MODEL, havingValue = SpringAIModels.OPENAI,
matchIfMissing = true)
@EnableConfigurationProperties({ OpenAiConnectionProperties.class, OpenAiImageEditProperties.class })
@ImportAutoConfiguration(classes = { SpringAiRetryAutoConfiguration.class, RestClientAutoConfiguration.class,
WebClientAutoConfiguration.class })
public class OpenAiImageEditAutoConfiguration {

@Bean
@ConditionalOnMissingBean
public OpenAiImageEditModel openAiImageEditModel(OpenAiConnectionProperties commonProperties,
OpenAiImageEditProperties imageEditProperties, ObjectProvider<RestClient.Builder> restClientBuilderProvider,
RetryTemplate retryTemplate, ResponseErrorHandler responseErrorHandler) {

OpenAIAutoConfigurationUtil.ResolvedConnectionProperties resolved = resolveConnectionProperties(
commonProperties, imageEditProperties, "image");

var openAiImageApi = OpenAiImageApi.builder()
.baseUrl(resolved.baseUrl())
.apiKey(new SimpleApiKey(resolved.apiKey()))
.headers(resolved.headers())
.restClientBuilder(restClientBuilderProvider.getIfAvailable(RestClient::builder))
.responseErrorHandler(responseErrorHandler)
.build();
var imageModel = new OpenAiImageEditModel(openAiImageApi, imageEditProperties.getOptions(), retryTemplate);
return imageModel;
}

}
Original file line number Diff line number Diff line change
@@ -0,0 +1,52 @@
/*
* Copyright 2023-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.ai.model.openai.autoconfigure;

import org.springframework.ai.openai.OpenAiImageEditOptions;
import org.springframework.ai.openai.OpenAiImageOptions;
import org.springframework.ai.openai.api.OpenAiImageApi;
import org.springframework.boot.context.properties.ConfigurationProperties;
import org.springframework.boot.context.properties.NestedConfigurationProperty;

/**
* OpenAI Image autoconfiguration properties.
*
* @author Minsoo Nam
* @since 1.0.0
*/
@ConfigurationProperties(OpenAiImageEditProperties.CONFIG_PREFIX)
public class OpenAiImageEditProperties extends OpenAiParentProperties {

public static final String CONFIG_PREFIX = "spring.ai.openai.image.edit";

public static final String DEFAULT_IMAGE_MODEL = OpenAiImageApi.ImageModel.DALL_E_2.getValue();

/**
* Options for OpenAI Image Edit API.
*/
@NestedConfigurationProperty
private OpenAiImageEditOptions options = OpenAiImageEditOptions.builder().model(DEFAULT_IMAGE_MODEL).build();

public OpenAiImageEditOptions getOptions() {
return this.options;
}

public void setOptions(OpenAiImageEditOptions options) {
this.options = options;
}

}
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
import org.springframework.ai.openai.OpenAiAudioTranscriptionModel;
import org.springframework.ai.openai.OpenAiChatModel;
import org.springframework.ai.openai.OpenAiEmbeddingModel;
import org.springframework.ai.openai.OpenAiImageEditModel;
import org.springframework.ai.openai.OpenAiImageModel;
import org.springframework.ai.openai.OpenAiModerationModel;
import org.springframework.boot.autoconfigure.AutoConfigurations;
Expand All @@ -33,6 +34,7 @@
* Unit Tests for OpenAI auto configurations' conditional enabling of models.
*
* @author Ilayaperumal Gopinathan
* @author Minsoo Nam
*/
public class OpenAiModelConfigurationTests {

Expand Down Expand Up @@ -171,6 +173,54 @@ void imageModelActivation() {
});
}

@Test
void imageEditModelActivation() {
this.contextRunner.withConfiguration(AutoConfigurations.of(OpenAiImageEditAutoConfiguration.class))
.run(context -> {
assertThat(context.getBeansOfType(OpenAiChatModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiEmbeddingModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiImageModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiImageEditModel.class)).isNotEmpty();
assertThat(context.getBeansOfType(OpenAiAudioSpeechModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiAudioTranscriptionModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiModerationModel.class)).isEmpty();
});

this.contextRunner.withConfiguration(AutoConfigurations.of(OpenAiImageEditAutoConfiguration.class))
.withPropertyValues("spring.ai.model.image.edit=none")
.run(context -> {
assertThat(context.getBeansOfType(OpenAiImageEditProperties.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiImageEditModel.class)).isEmpty();
});

this.contextRunner.withConfiguration(AutoConfigurations.of(OpenAiImageEditAutoConfiguration.class))
.withPropertyValues("spring.ai.model.image.edit=openai")
.run(context -> {
assertThat(context.getBeansOfType(OpenAiImageEditProperties.class)).isNotEmpty();
assertThat(context.getBeansOfType(OpenAiImageEditModel.class)).isNotEmpty();
});

this.contextRunner
.withConfiguration(
AutoConfigurations.of(OpenAiChatAutoConfiguration.class, OpenAiEmbeddingAutoConfiguration.class,
OpenAiImageEditAutoConfiguration.class, OpenAiAudioSpeechAutoConfiguration.class,
OpenAiAudioTranscriptionAutoConfiguration.class, OpenAiModerationAutoConfiguration.class))
.withPropertyValues("spring.ai.model.chat=none", "spring.ai.model.embedding=none",
"spring.ai.model.image=none", "spring.ai.model.image.edit=openai",
"spring.ai.model.audio.speech=none", "spring.ai.model.audio.transcription=none",
"spring.ai.model.moderation=none")
.withConfiguration(AutoConfigurations.of(OpenAiImageAutoConfiguration.class))
.run(context -> {
assertThat(context.getBeansOfType(OpenAiChatModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiEmbeddingModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiImageModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiImageEditModel.class)).isNotEmpty();
assertThat(context.getBeansOfType(OpenAiAudioSpeechModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiAudioTranscriptionModel.class)).isEmpty();
assertThat(context.getBeansOfType(OpenAiModerationModel.class)).isEmpty();
});
}

@Test
void audioSpeechModelActivation() {
this.contextRunner.withConfiguration(AutoConfigurations.of(OpenAiAudioSpeechAutoConfiguration.class))
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -321,6 +321,31 @@ public void imageProperties() {
});
}

@Test
public void imageEditProperties() {
new ApplicationContextRunner().withPropertyValues(
// @formatter:off
"spring.ai.openai.base-url=TEST_BASE_URL",
"spring.ai.openai.api-key=abc123",
"spring.ai.openai.image.edit.options.model=MODEL_XYZ",
"spring.ai.openai.image.edit.options.n=3")
// @formatter:on
.withConfiguration(AutoConfigurations.of(OpenAiImageEditAutoConfiguration.class))
.run(context -> {
var imageEditProperties = context.getBean(OpenAiImageEditProperties.class);
var connectionProperties = context.getBean(OpenAiConnectionProperties.class);

assertThat(connectionProperties.getApiKey()).isEqualTo("abc123");
assertThat(connectionProperties.getBaseUrl()).isEqualTo("TEST_BASE_URL");

assertThat(imageEditProperties.getApiKey()).isNull();
assertThat(imageEditProperties.getBaseUrl()).isNull();

assertThat(imageEditProperties.getOptions().getModel()).isEqualTo("MODEL_XYZ");
assertThat(imageEditProperties.getOptions().getN()).isEqualTo(3);
});
}

@Test
public void imageOverrideConnectionProperties() {
new ApplicationContextRunner().withPropertyValues(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,6 +232,13 @@ public String toString() {

public enum ImageModel {

/**
* GPT Image 1 is our new state-of-the-art image generation model. It is a
* natively multimodal language model that accepts both text and image inputs, and
* produces image outputs.
*/
GPT_IMAGE_1("gpt-image-1"),

/**
* The latest DALL·E model released in Nov 2023.
*/
Expand Down
Loading