Skip to content

Fix typos #3695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 1, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ public class McpToolCallbackAutoConfigurationTests {
.withConfiguration(AutoConfigurations.of(McpToolCallbackAutoConfiguration.class));

@Test
void enableddByDefault() {
void enabledByDefault() {

this.applicationContext.run(context -> {
assertThat(context).hasBean("mcpToolCallbacks");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ void sseParametersRecord() {
}

@Test
void sseParametersRecordWithNullSseEdnpoint() {
void sseParametersRecordWithNullSseEndpoint() {
String url = "http://test-server:8080/events";
McpSseClientProperties.SseParameters params = new McpSseClientProperties.SseParameters(url, null);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2023-2024 the original author or authors.
* Copyright 2023-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -43,7 +43,7 @@
class TranscriptionModelTests {

@Test
void transcrbeRequestReturnsResponseCorrectly() {
void transcribeRequestReturnsResponseCorrectly() {

Resource mockAudioFile = Mockito.mock(Resource.class);

Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright 2023-2024 the original author or authors.
* Copyright 2023-2025 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -157,7 +157,7 @@ public void openAiChatNonTransientError() {
}

@Test
@Disabled("Currently stream() does not implmement retry")
@Disabled("Currently stream() does not implement retry")
public void openAiChatStreamTransientError() {

var choice = new ChatCompletionChunk.ChunkChoice(ChatCompletionFinishReason.STOP, 0,
Expand All @@ -179,7 +179,7 @@ public void openAiChatStreamTransientError() {
}

@Test
@Disabled("Currently stream() does not implmement retry")
@Disabled("Currently stream() does not implement retry")
public void openAiChatStreamNonTransientError() {
given(this.openAiApi.chatCompletionStream(isA(ChatCompletionRequest.class), any()))
.willThrow(new RuntimeException("Non Transient Error"));
Expand Down
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about changing the method names as follows:
paymentStatusgetPaymentStatus
statusesPaymentStatusesgetPaymentStatuses

Original file line number Diff line number Diff line change
Expand Up @@ -76,14 +76,14 @@ public void paymentStatuses() {

String content = this.chatClient.prompt()
.advisors(new SimpleLoggerAdvisor())
.toolNames("paymentStatus")
.toolNames("getPaymentStatus")
.user("""
What is the status of my payment transactions 001, 002 and 003?
If requred invoke the function per transaction.
If required invoke the function per transaction.
""")
.call()
.content();
logger.info("" + content);
logger.info(content);

assertThat(content).contains("001", "002", "003");
assertThat(content).contains("pending", "approved", "rejected");
Expand All @@ -94,10 +94,10 @@ public void streamingPaymentStatuses() {

Flux<String> streamContent = this.chatClient.prompt()
.advisors(new SimpleLoggerAdvisor())
.toolNames("paymentStatus")
.toolNames("getPaymentStatuses")
.user("""
What is the status of my payment transactions 001, 002 and 003?
If requred invoke the function per transaction.
If required invoke the function per transaction.
""")
.stream()
.content();
Expand Down Expand Up @@ -130,13 +130,13 @@ record Status(String name) {
public static class PaymentService {

@Tool(description = "Get the status of a single payment transaction")
public Status paymentStatus(Transaction transaction) {
public Status getPaymentStatus(Transaction transaction) {
logger.info("Single Transaction: " + transaction);
return DATASET.get(transaction);
}

@Tool(description = "Get the list statuses of a list of payment transactions")
public List<Status> statusespaymentStatuses(List<Transaction> transactions) {
public List<Status> getPaymentStatuses(List<Transaction> transactions) {
logger.info("Transactions: " + transactions);
return transactions.stream().map(t -> DATASET.get(t)).toList();
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ public void paymentStatuses() {
.tools(new MyTools())
.user("""
What is the status of my payment transactions 001, 002 and 003?
If requred invoke the function per transaction.
If required invoke the function per transaction.
""").call().content();
// @formatter:on
logger.info("" + content);
Expand All @@ -93,7 +93,7 @@ public void streamingPaymentStatuses() {
.tools(new MyTools())
.user("""
What is the status of my payment transactions 001, 002 and 003?
If requred invoke the function per transaction.
If required invoke the function per transaction.
""")
.stream()
.content();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
import static org.assertj.core.api.Assertions.assertThat;

/**
* Example integration-test to use against the schema and full wiki datasets in sstable
* Example integration-test to use against the schema and full wiki datasets in stable
* format available from https://github.com/datastax-labs/colbert-wikipedia-data
*
* Use `mvn failsafe:integration-test -Dit.test=WikiVectorStoreExample`
Expand Down Expand Up @@ -106,7 +106,7 @@ public CassandraVectorStore store(CqlSession cqlSession, EmbeddingModel embeddin
.addMetadataColumns(extraColumns)
.primaryKeyTranslator((List<Object> primaryKeys) -> {
// the deliminator used to join fields together into the document's id
// is arbitary, here "§¶" is used
// is arbitrary, here "§¶" is used
if (primaryKeys.isEmpty()) {
return "test§¶0";
}
Expand Down