#2528 Batch processing of messages: When one of the messages encounters a parsing exception, only the exception messages are rejected, not all of them #2531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ssages encounters a parsing exception, only the exception messages are rejected, not all of them
garyrussell
suggested changes
Sep 27, 2023
| Message<?> messagingMessage = toMessagingMessage(message); | ||
| messagingMessages.add(messagingMessage); | ||
| } catch (MessageConversionException e) { | ||
| this.logger.trace("Could not convert incoming message", e); |
There was a problem hiding this comment.
Thanks; this should work, but the log should be error().
Also, please add a test.
There was a problem hiding this comment.
ok, It's all resolved
garyrussell
suggested changes
Sep 28, 2023
There was a problem hiding this comment.
Error: eckstyle] [ERROR] /home/runner/work/spring-amqp/spring-amqp/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/BatchMessagingMessageListenerAdapter.java:70:17: '}' at column 17 should be alone on a line. [RightCurly]
Error: eckstyle] [ERROR] /home/runner/work/spring-amqp/spring-amqp/spring-rabbit/src/main/java/org/springframework/amqp/rabbit/listener/adapter/BatchMessagingMessageListenerAdapter.java:74:41: '}' at column 6 should be alone on a line. [RightCurly]
It's a bit different from my habits, but I have already made the necessary changes according to the regulations |
|
Thanks for the contribution! Merged as e521033 after polishing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Batch processing of messages: When one of the messages encounters a parsing exception, only the exception messages are rejected, not all of them。