Usability improvements: New SuperStream builder #2541
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
builder provide a way to configure: - maxAge - maxLength - maxSegmentSize
garyrussell
suggested changes
Oct 9, 2023
spring-rabbit-stream/src/main/java/org/springframework/rabbit/stream/config/SuperStream.java
Show resolved
Hide resolved
spring-rabbit-stream/src/main/java/org/springframework/rabbit/stream/config/SuperStream.java
Show resolved
Hide resolved
...rabbit-stream/src/main/java/org/springframework/rabbit/stream/config/SuperStreamBuilder.java
Outdated
Show resolved
Hide resolved
Fix style tests and add a new one for the super stream builder
garyrussell
suggested changes
Oct 11, 2023
| @@ -37,7 +38,6 @@ | |||
| * | |||
| * @author Gary Russell | |||
There was a problem hiding this comment.
Please add yourself to the author list.
| /** | ||
| * Creates a builder for Super Stream. | ||
| * | ||
| * @param name stream name |
There was a problem hiding this comment.
Suggested change
| * @param name stream name | |
| * @param name stream name |
Remove extra spaces, we don't align param descriptions by column.
|
|
||
| /** | ||
| * Set the stream name. | ||
| * |
There was a problem hiding this comment.
No blank lines in method javadocs (this one and others below).
| * @author Sergei Kurenchuk | ||
| * @since 3.1 | ||
| */ | ||
| public class SuperStreamConfigurationTest { |
There was a problem hiding this comment.
Suggested change
| public class SuperStreamConfigurationTest { | |
| public class SuperStreamConfigurationTests { |
Our convention is ...Tests.
|
Also, you mentioned |
Covered x-initial-cluster-size. Fixes after review
garyrussell
approved these changes
Oct 12, 2023
|
Thanks! Merged as 3620f11 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
builder provide a way to configure:
The Issue: #2540