Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-2552: Fix Builder Argument Types maxLength etc #2553

Merged
merged 1 commit into from
Oct 31, 2023
Merged

GH-2552: Fix Builder Argument Types maxLength etc #2553

merged 1 commit into from
Oct 31, 2023

Conversation

garyrussell
Copy link
Contributor

Resolves #2552

Variables map to Erlang ints which are 8 bytes, so need to be long in Java.

@garyrussell
spring-projectsGH-2552: Fix Builder Argument Types maxLength etc
e7d2ca9 
Resolves spring-projects#2552

Variables map to Erlang ints which are 8 bytes, so need to be long in Java.
@artembilan artembilan merged commit 613c289 into spring-projects:main Oct 31, 2023
2 checks passed
@artembilan
Copy link
Member

@garyrussell ,

is this supposed to be back-ported to 3.0.x ?

@garyrussell
Copy link
Contributor Author

No; SuperStreamBuilder doesn't exist there.

I suppose we could back port the QueueBuilder part, but nobody has complained about it so we can defer that, I think.

@garyrussell
Copy link
Contributor Author

Also, maxLength is messages there (Vs. bytes with streams) so it's probably less of an issue for queues.

@garyrussell garyrussell deleted the GH-2552 branch November 20, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Stream/Queue size in bytes (x-max-length-bytes)
2 participants
@garyrussell @artembilan