-
Notifications
You must be signed in to change notification settings - Fork 2.4k
Add a description for a step both with the XML and Java configuration styles #4830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add description field and methods to AbstractJob class - Implement description setting in JobBuilderHelper - Add test cases for both XML and Java configurations - Update documentation with usage examples Signed-off-by: minkukjo <[email protected]>
Signed-off-by: minkukjo <[email protected]>
/** | ||
* @author Minkuk Jo | ||
*/ | ||
public class TestTasklet implements Tasklet { | ||
|
||
@Override | ||
public RepeatStatus execute(StepContribution contribution, ChunkContext chunkContext) { | ||
return RepeatStatus.FINISHED; | ||
} | ||
|
||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created this class expecting it to be used globally in my tests, but would it have been better to create it as an inner class in JobXmlDescriptionTests?
Signed-off-by: Harry <[email protected]>
Hi, @fmbenhassine I hope you're doing well. I just wanted to kindly follow up on my PR Thank you for your time and for maintaining this great project! Best regards, |
Signed-off-by: Harry <[email protected]>
Fixes: #4826
What is the problem
What I Did