Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support config yaml files embedded in env vars via spring.config.import #43657

Closed
wants to merge 1 commit into from
Closed

Support config yaml files embedded in env vars via spring.config.import #43657

wants to merge 1 commit into from

Conversation

chicobento
Copy link
Contributor

@chicobento chicobento commented Jan 3, 2025 •
edited
Loading

Related to #41609.

TODO:

  • Improve/discuss support for EnvironmentVariableResource/ProtocolHandler
  • Define 3PP for provisioning env vars
  • Test coverage
  • Docs

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Jan 3, 2025
@chicobento chicobento force-pushed the config_as_env_var branch 5 times, most recently from 3e2c7b4 to c7ce726 Compare January 3, 2025 19:38
@mhalbritter mhalbritter added the for: team-meeting An issue we'd like to discuss as a team to make progress label Jan 16, 2025
@mhalbritter
Copy link
Contributor

I have an implementation for that feature in https://github.com/mhalbritter/sb-41609 and used a ConfigDataLocationResolver and ConfigDataLoader.

I want to discuss with the team which approach would be more suitable.

@chicobento
Copy link
Contributor Author

I have an implementation for that feature in https://github.com/mhalbritter/sb-41609 and used a ConfigDataLocationResolver and ConfigDataLoader.

I want to discuss with the team which approach would be more suitable.

Hi @mhalbritter , I went that path in my first implementation, dont recall why I changed direction, I think it was to support profiles but Im not sure. Nevertheless Im happy with both solutions, profile is not a big issue for us if that was the case.

@mhalbritter mhalbritter self-assigned this Jan 29, 2025
@mhalbritter mhalbritter added status: declined A suggestion or change that we don't feel we should currently apply and removed for: team-meeting An issue we'd like to discuss as a team to make progress status: waiting-for-triage An issue we've not yet triaged labels Jan 29, 2025
@mhalbritter
Copy link
Contributor

Hey, thanks for the PR. We decided to implement it via a ConfigDataLoader.

@chicobento
Copy link
Contributor Author

Nevermind, @mhalbritter Im happy with that 🎉🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mhalbritter mhalbritter

Labels
status: declined A suggestion or change that we don't feel we should currently apply
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chicobento @mhalbritter @spring-projects-issues