Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NPE when parsing modifying HQL #3650

Closed
wants to merge 3 commits into from
Closed

Fix NPE when parsing modifying HQL #3650

wants to merge 3 commits into from
+28 −17

Conversation

christophstrobl
Copy link
Member

@christophstrobl christophstrobl commented Oct 25, 2024 •
edited
Loading

Resolves: #3649

Needs to be forward ported to 3.3.x and main.

mp911de
mp911de reviewed Oct 25, 2024
View reviewed changes
...ata-jpa/src/main/java/org/springframework/data/jpa/repository/query/HqlQueryTransformer.java
} else if (ctx instanceof HqlParser.DeleteStatementContext) {
return false;
} else if (ctx instanceof HqlParser.UpdateStatementContext) {
return false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add another guard in case the parent is empty to eliminate this bug class for future revisions.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah - sounds good - let me do that

@mp911de mp911de added the type: regression A regression from a previous release label Oct 25, 2024
@mp911de mp911de linked an issue Oct 25, 2024 that may be closed by this pull request
NPE in HqlQueryTransformer.isSubquery for UPDATE HQL #3649
Closed
@mp911de mp911de changed the title Fix NPE when parsing modifying HQL. Fix NPE when parsing modifying HQL Oct 25, 2024
@mp911de mp911de added this to the 3.2.12 (2023.1.12) milestone Oct 25, 2024
mp911de pushed a commit that referenced this pull request Oct 25, 2024
@christophstrobl @mp911de
Fix NPE when parsing modifying HQL.
84e0e32 
Closes #3649
Original pull request: #3650
mp911de added a commit that referenced this pull request Oct 25, 2024
@mp911de
Polishing.
d955b78 
Simplify code.

See #3649
Original pull request: #3650
mp911de pushed a commit that referenced this pull request Oct 25, 2024
@christophstrobl @mp911de
Fix NPE when parsing modifying HQL.
fa17008 
Closes #3649
Original pull request: #3650
mp911de added a commit that referenced this pull request Oct 25, 2024
@mp911de
Polishing.
abbbc69 
Simplify code.

See #3649
Original pull request: #3650
mp911de pushed a commit that referenced this pull request Oct 25, 2024
@christophstrobl @mp911de
Fix NPE when parsing modifying HQL.
490d34a 
Closes #3649
Original pull request: #3650
@mp911de mp911de closed this Oct 25, 2024
@mp911de mp911de deleted the issue/3.2.x/3649 branch October 25, 2024 13:32
@christophstrobl christophstrobl mentioned this pull request Nov 6, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mp911de mp911de mp911de left review comments

Assignees

@mp911de mp911de

Labels
type: regression A regression from a previous release
Projects
None yet
Milestone
3.2.12 (2023.1.12)
Development

Successfully merging this pull request may close these issues.

NPE in HqlQueryTransformer.isSubquery for UPDATE HQL
2 participants
@christophstrobl @mp911de