Skip to content

Commit

Permalink
Add Unit Test for fixing wrong return type when invoking Async-annota…
Browse files Browse the repository at this point in the history
…ted on interface
  • Loading branch information
anaconda874 committed Nov 27, 2024
1 parent a076999 commit 64d289a
Show file tree
Hide file tree
Showing 2 changed files with 75 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@
* @author Juergen Hoeller
* @author Chris Beams
* @author Stephane Nicoll
* @author Bao Ngo
* @since 3.0
* @see org.springframework.scheduling.annotation.Async
* @see org.springframework.scheduling.annotation.AsyncAnnotationAdvisor
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/*
* Copyright 2002-2024 the original author or authors.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

package org.springframework.aop.interceptor;

import java.util.concurrent.Callable;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.Future;

import org.aopalliance.intercept.MethodInvocation;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;

import org.springframework.core.task.AsyncTaskExecutor;

import static org.assertj.core.api.Assertions.assertThat;
import static org.mockito.BDDMockito.given;
import static org.mockito.Mockito.any;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.spy;
import static org.mockito.Mockito.verify;


/**
* Tests for {@link AsyncExecutionInterceptor}.
*
* @author Bao Ngo
* @since 7.0
*/
class AsyncExecutionInterceptorTests {

@Test
public void testInvokeOnInterface() throws Throwable {
AsyncExecutionInterceptor interceptor = spy( new AsyncExecutionInterceptor( null ) );
Impl impl = new Impl();
ArgumentCaptor<Class<?>> classArgumentCaptor = ArgumentCaptor.forClass( Class.class );
MethodInvocation mi = mock();
given( mi.getThis() ).willReturn( impl );
given( mi.getMethod() ).willReturn( I.class.getMethod( "doSomeThing" ) );
interceptor.invoke( mi );
verify( interceptor ).doSubmit(
any( Callable.class ),
any( AsyncTaskExecutor.class ),
classArgumentCaptor.capture()
);
assertThat( classArgumentCaptor.getValue() ).isEqualTo( Future.class );
}


private interface I<O> {
O doSomeThing();
}

private static final class Impl implements I<Future<Void>> {
@Override
public Future<Void> doSomeThing() {
return CompletableFuture.runAsync( () -> {
} );
}
}
}

0 comments on commit 64d289a

Please sign in to comment.