Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ensure protocol slashes are preserved in getSanitizedPath #33978

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Ensure protocol slashes are preserved in getSanitizedPath #33978

wants to merge 2 commits into from
+49 −9

Conversation

sanhee
Copy link

@sanhee sanhee commented Nov 27, 2024

Description

Fixed an issue in getSanitizedPath where slashes in protocols like http:// were incorrectly removed.

Changes

  • Added checks to ensure protocol slashes are preserved.
  • Cleaned up redundant slashes in the path without affecting the protocol.

Test

  • Verified with multiple inputs, including paths with and without protocols, to ensure correct behavior.
  • Added unit tests for edge cases.
AS-IS TO-BE
스크린샷 2024-11-27 오후 11 50 32 image

@sanhee
fix: Ensure protocol slashes are preserved in getSanitizedPath
089271c 
Fixed an issue where `getSanitizedPath` incorrectly removed slashes in protocols like `http://`.
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
status: waiting-for-triage An issue we've not yet triaged or decided on
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanhee @spring-projects-issues