Polish YamlProcessor #34665
Closed
Polish YamlProcessor #34665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The result of `yaml.loadAll(reader)` will never contains null element. Signed-off-by: Yanming Zhou <[email protected]>
|
Not sure null check required here. |
spring-projects-issues
added
the
status: waiting-for-triage
rstoyanchev
added
type: task
rstoyanchev
reviewed
Jun 10, 2025
There was a problem hiding this comment.
On closer look, not so easy to verify. loadAll calls constructor.getData() and that in turn calls constructObject which does a lookup into a Map, and even if the key is present, the value could be null. I didn't trace it further, but I think the null check is worth having as protection.
rstoyanchev
added
the
status: declined
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result of
yaml.loadAll(reader)will never contains null element.