polish receive() aop advice and its triggers
#10305
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove redundant interface for class `CompoundTriggerAdvice` * fix potential NPE in `DynamicPeriodicTrigger#nextExecution` Signed-off-by: Jiandong Ma <[email protected]>
artembilan
requested changes
Aug 12, 2025
| return | ||
| triggerContext.lastCompletion().plus(this.duration); // NOSONAR never null here | ||
| Instant lastCompletion = triggerContext.lastCompletion(); | ||
| return Objects.requireNonNullElse(lastCompletion, clock.instant()).plus(this.duration); |
There was a problem hiding this comment.
I prefer if..else instead in critical path execution.
Signed-off-by: Jiandong Ma <[email protected]>
FileTests > testFileSplitterFlow() FAILED
java.lang.AssertionError at FileTests.java:262looks the error isn't related to the new changes, local file module is green, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CompoundTriggerAdviceDynamicPeriodicTrigger#nextExecution