GH-2968 DefaultErrorHandler#handleBatchAndReturnRemaining recovered invalid
#2969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobychacko
reviewed
Dec 22, 2023
| } | ||
| catch (Exception e) { | ||
| } |
There was a problem hiding this comment.
Empty catch - can we address this?
|
I went through the PR. It looks good. Could you explain why it is not a problem when the record that throws the error is not the last one in the partition? |
I got it wrong, error record must be first one in remaining list. Fixed PR expressions. |
…ing recovered invalid DefaultErrorHandler#handleBatchAndReturnRemaining recovered invalid and infinite loop when kafka listener threw BatchListenerFailedException and error record is first one in remaining list * address empty catch * add unit test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2968
DefaultErrorHandler#handleBatchAndReturnRemainingrecovered invalid and infinite loop when kafka listener threw BatchListenerFailedException and error record is first one in remaining list..