@RetryableTopic support @KafkaListener annotated on class part 1 #3107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobychacko
requested changes
Mar 8, 2024
| } | ||
|
|
||
| @Nullable | ||
| public RetryTopicConfiguration findRetryConfigurationFor(String[] topics, @Nullable Method method, |
There was a problem hiding this comment.
Why does it need to be public? If it's valid, add the since tag and a note in whats-new as this is a new public API.
* Support process `@RetryableTopic` from Class in `RetryTopicConfigurationProvider`. * Support process `@DltHandler` when `@RetryableTopic` annotated on the Class in `RetryableTopicAnnotationProcessor`. part of spring-projects#3105
Wzy19930507
force-pushed
the
GH-3012_part_1
branch
from
f65b65c
to
304a1bf
Compare
Wzy19930507
changed the title
@RetryableTopic support @KafkaListener annotated on class part 1
sobychacko
approved these changes
Mar 8, 2024
sobychacko
pushed a commit
that referenced
this pull request
Mar 18, 2024
Fixes: #3012 * Non-blocking retries support for `@KafkaListener` on class level, which includes `@RetryableTopic,` `@DltHandler,` `RetryTopicConfiguration,` and `RetryTopicConfigurationSupport.` * Doc and test for Non-blocking retries support for @KafkaListener on class level. * Addressing PR review. See these earlier related PRs: #3112 #3107
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@RetryableTopicsupport annotated on Class.@RetryableTopicfrom Class inRetryTopicConfigurationProvider.@DltHandlerwhen@RetryableTopicannotated on the Class inRetryableTopicAnnotationProcessor.part of #3105