Remove org.apache.kafka native runtime hints #3147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
sobychacko
commented
Mar 21, 2024
•
sobychacko
commented
- Since several of the native runtime hints that Spring for Apache Kafka provides for org.apahce.kafka classes are available via the graalvm-reachability-metadata repository (https://github.com/oracle/graalvm-reachability-metadata), we are no longer keeping these runtime hints in Spring for Apache Kafka since version 3.2.0. This applies to both kafka-client classes and Kafka Streams classes.
artembilan
requested changes
Mar 21, 2024
| // standard partitioners | ||
| org.apache.kafka.clients.producer.internals.DefaultPartitioner.class, | ||
| RoundRobinPartitioner.class, | ||
| org.apache.kafka.clients.producer.UniformStickyPartitioner.class, |
There was a problem hiding this comment.
Why do we still keep this Kafka client classes here?
There was a problem hiding this comment.
Missing in the metadata repo.
There was a problem hiding this comment.
Apparently both of these classes are deprecated now.
And according to their Javadocs they are not recommended to be used at all.
So, it is safe to remove them from here even now.
spring-kafka/src/main/java/org/springframework/kafka/aot/KafkaRuntimeHints.java
Show resolved
Hide resolved
* Since several of the native runtime hints that Spring for Apache Kafka provides for org.apahce.kafka classes are available via the graalvm-reachability-metadata repository (https://github.com/oracle/graalvm-reachability-metadata), we are no longer keeping these runtime hints in Spring for Apache Kafka since version 3.2.0. This applies to both kafka-client classes and Kafka Streams classes.
sobychacko
force-pushed
the
aot-runtime-hints-cleanup
branch
from
1dd1593
to
71cef5a
Compare
artembilan
requested changes
Mar 21, 2024
| // standard partitioners | ||
| org.apache.kafka.clients.producer.internals.DefaultPartitioner.class, | ||
| RoundRobinPartitioner.class, | ||
| org.apache.kafka.clients.producer.UniformStickyPartitioner.class, |
There was a problem hiding this comment.
Apparently both of these classes are deprecated now.
And according to their Javadocs they are not recommended to be used at all.
So, it is safe to remove them from here even now.
spring-kafka/src/main/java/org/springframework/kafka/aot/KafkaRuntimeHints.java
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.