Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-2609: providing more tracing tags #3169

Merged
merged 7 commits into from
Apr 8, 2024

Conversation

Wzy19930507
Copy link
Contributor

Fixes: #2609

detail see #2616.

  • fix review.
  • polish ObservationTests.
  • add doc in whats-new.adoc.

Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into this!
Please, find some my requests about improvements.

* add javadoc for `KafkaRecordReceiverContext` construct method.
Copy link
Member

@artembilan artembilan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor clean ups according to our code style.

Thanks

@artembilan artembilan merged commit df8b7a1 into spring-projects:main Apr 8, 2024
3 checks passed
@Wzy19930507 Wzy19930507 deleted the GH-2609_2024 branch April 9, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

More and proper tags for observation spans
3 participants