-
Notifications
You must be signed in to change notification settings - Fork 24k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "Open with Codeanywhere" badge #1717
base: main
Are you sure you want to change the base?
Add "Open with Codeanywhere" badge #1717
Conversation
@ivan-burazin Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
@ivan-burazin Thank you for signing the Contributor License Agreement! |
I like it. I'm not sure if we should have this link though (also the Gitpod one really) since it requires unlimited repository access in Github, and that's not something I want people to give away lightly, or with an implied recommendation from the PetClinic team. |
Hi @dsyer, Would that be an adequate solution? |
I think the problem is requiring write access to any repo (public or private). I don't want to give random third parties those kinds of permissions, and I don't want to encourage other people to do that either. I don't need write access to anything (except some storage) to explore a clone of a public repo in my own environment. I appreciate you don't have many options, and GitHub is making things hard for you. |
How would you edit it in a Cloud environment without write access? I understand the worries about private repo, but what would be the danger's of public? I completely understand that you can say no to this PR, but honestly interested. |
You can edit a clone without any special access, and that might be enough to get started. You can't commit it without a private key, or an access token like you are asking for. That's where things get sticky I guess. The access is too high to grant to an unknown 3rd party. |
Add "Open with Codeanywhere" Badge
Why? With Codeanywhere, contributors can:
devcontainer.json
file is present (such as this repo).Benefits: