TestCsrfTokenRepository should delegate to the configured CsrfTokenRepository #13082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spring-projects-issues
added
the
status: waiting-for-triage
chschu
force-pushed
the
bugfix/TestCsrfTokenRepository-delegate-to-actual-CsrfTokenRepository
branch
from
847b02e to
9a736dd
Compare
…ry configured in CsrfFilter
chschu
force-pushed
the
bugfix/TestCsrfTokenRepository-delegate-to-actual-CsrfTokenRepository
branch
from
9a736dd to
b673748
Compare
|
@chschu, I'm going through some older PRs and noticed that this has not had an update in over a year. I'm going to go ahead and close this for now. If you would like to work on it again, feel free to create a new PR from a fresh (or rebased) branch and we'll take a look. Or if you'd like this PR reopened, please add a comment and ping myself or someone on the team and we'll be happy to reopen it for you. |
sjohnr
added
in: test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm creating this as a draft, because there are some failing tests I need to fix before this can be merged.
CsrfRequestPostProcessorcurrently reconfiguresCsrfFilterwith aTestCsrfTokenRepositorythat delegates to a newly createdHttpSessionCsrfTokenRepository. This is fine as long as the configuredCsrfTokenRepositoryis aHttpSessionCsrfTokenRepositoryas well, because it accesses the same session attribute.However, if the configured
CsrfTokenRepositoryis not aHttpSessionCsrfTokenRepository, this change affects (and may break) any test that uses the same cachedApplicationContext, because it now basically uses aHttpSessionCsrfTokenRepositoryinstead of the configuredCsrfTokenRepository.TestCsrfTokenRepositoryshould delegate to the configuredCsrfTokenRepositoryto avoid affecting unrelated tests.