Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AuthorizationManager factory methods #14180

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add AuthorizationManager factory methods #14180

merged 1 commit into from
Dec 7, 2023

Conversation

ysavchen
Copy link
Contributor

Factory methods to create AuthorizationManager with a configurable default AuthorizationDecision.

Closes gh-13085

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 21, 2023
@jzheaux jzheaux self-assigned this Nov 28, 2023
@jzheaux jzheaux added status: duplicate A duplicate of another issue in: core An issue in spring-security-core type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Nov 28, 2023
@jzheaux jzheaux added this to the 6.3.0-M1 milestone Nov 28, 2023
jzheaux
jzheaux requested changes Dec 1, 2023
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ysavchen! I've left some feedback inline.

core/src/main/java/org/springframework/security/authorization/AuthorizationManagers.java Outdated Show resolved Hide resolved
core/src/test/java/org/springframework/security/authorization/AuthorizationManagersTests.java Show resolved Hide resolved
core/src/main/java/org/springframework/security/authorization/AuthorizationManagers.java Show resolved Hide resolved
@ysavchen
Copy link
Contributor Author

ysavchen commented Dec 3, 2023

Thank you for the review, @jzheaux
Updated the PR

@ysavchen ysavchen requested a review from jzheaux December 3, 2023 10:27
@ysavchen
Add AuthorizationManager factory methods
cbf1fbe 
Factory methods to create AuthorizationManager with a configurable default AuthorizationDecision.

Closes gh-13085
@ysavchen
Copy link
Contributor Author

ysavchen commented Dec 7, 2023

Updated the PR to remove code duplication

@jzheaux jzheaux merged commit e49ae09 into spring-projects:main Dec 7, 2023
1 check passed
@ysavchen ysavchen deleted the gh-13085 branch June 11, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: core An issue in spring-security-core status: duplicate A duplicate of another issue type: enhancement A general enhancement
Projects
Spring Security Team
Status: Done
Milestone
6.3.0-M1
Development

Successfully merging this pull request may close these issues.

AuthorizationManagers should allow a configurable default AuthorizationDecision
3 participants
@ysavchen @jzheaux @spring-projects-issues