Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow configuring custom ServerHttpHeadersWriter for Kotlin DSL #16136

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Allow configuring custom ServerHttpHeadersWriter for Kotlin DSL #16136

merged 1 commit into from
Dec 17, 2024

Conversation

evgeniycheban
Copy link
Contributor

Closes gh-16009

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Nov 20, 2024
@evgeniycheban evgeniycheban force-pushed the gh-16009 branch 2 times, most recently from 9dc0509 to 7c59a4d Compare November 20, 2024 11:27
@jzheaux jzheaux self-assigned this Dec 5, 2024
@jzheaux jzheaux added in: config An issue in spring-security-config type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Dec 5, 2024
@jzheaux jzheaux added this to the 6.5.x milestone Dec 5, 2024
jzheaux
jzheaux requested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@jzheaux jzheaux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @evgeniycheban! Could we avoid adding the extra DSL layer? Please see my inline comment for more details.

config/src/test/kotlin/org/springframework/security/config/web/server/ServerHeadersDslTests.kt Outdated Show resolved Hide resolved
@evgeniycheban evgeniycheban requested a review from jzheaux December 9, 2024 00:47
@evgeniycheban
Copy link
Contributor Author

Hi, @jzheaux I just updated PR according to your comments.

@jzheaux
Copy link
Contributor

jzheaux commented Dec 9, 2024

Great, @evgeniycheban. We'll go ahead and merge this after we cut the 6.4.x maintenance branch.

@evgeniycheban
Copy link
Contributor Author

@jzheaux should I add since 6.5 tag?

@jzheaux
Copy link
Contributor

jzheaux commented Dec 14, 2024

@evgeniycheban, yes please, and thank you.

@jzheaux jzheaux modified the milestones: 6.5.x, 6.5.0-M1 Dec 14, 2024
@evgeniycheban
Copy link
Contributor Author

@jzheaux I added since 6.5 tag to writer function.

@jzheaux jzheaux merged commit f45cc22 into spring-projects:main Dec 17, 2024
6 checks passed
@jzheaux
Copy link
Contributor

jzheaux commented Dec 17, 2024

Thanks, @evgeniycheban, for the PR! It was nice to work with you again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jzheaux jzheaux jzheaux approved these changes

Assignees

@jzheaux jzheaux

Labels
in: config An issue in spring-security-config type: enhancement A general enhancement
Projects
None yet
Milestone
6.5.0-M1
Development

Successfully merging this pull request may close these issues.

ServerHeadersDsl doesn't allow addition of custom ServerHttpHeadersWriter
3 participants
@evgeniycheban @jzheaux @spring-projects-issues