Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused code from WebSecurityConfiguration #16348

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Remove unused code from WebSecurityConfiguration #16348

merged 1 commit into from
Jan 9, 2025

Conversation

kse-music
Copy link
Contributor

@kse-music kse-music commented Dec 27, 2024 •
edited by rwinch
Loading

Remove unused code，webSecurityConfigurers and beanClassLoader

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 27, 2024
@rwinch rwinch self-requested a review January 7, 2025 20:16
@rwinch
Copy link
Member

rwinch commented Jan 7, 2025

Thanks for the PR @kse-music!

Can you please split this up into two commits and pull requests? This helps us to better track changes.

Use ObjectProvider instead of @Autowired HttpSecurity because when the user provides a SecurityFilterChain bean, it will still inject HttpSecurity. Since HttpSecurity is a prototype bean, this avoids its instantiation.

Can you please add a test that includes a comment to the PR (e.g. gh-16348) to verify that is the case?

rwinch
rwinch requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@rwinch rwinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the PR. I've provided feedback in a comment that needs addressed.

@kse-music kse-music mentioned this pull request Jan 8, 2025
Merged
@kse-music
Copy link
Contributor Author

@rwinch All the feedback has been addressed as you expected.

@rwinch rwinch changed the title Polish WebSecurityConfiguration Remove unused code from WebSecurityConfiguration Jan 9, 2025
@rwinch rwinch self-assigned this Jan 9, 2025
@rwinch rwinch added in: config An issue in spring-security-config type: task A general task and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 9, 2025
@rwinch rwinch added this to the 6.5.0-M1 milestone Jan 9, 2025
@rwinch rwinch merged commit 6cfc372 into spring-projects:main Jan 9, 2025
6 checks passed
@rwinch
Copy link
Member

rwinch commented Jan 9, 2025

Thanks for the Pull Request! This is now merged into main 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwinch rwinch rwinch requested changes

Assignees

@rwinch rwinch

Labels
in: config An issue in spring-security-config type: task A general task
Projects
None yet
Milestone
6.5.0-M1
Development

Successfully merging this pull request may close these issues.
3 participants
@kse-music @rwinch @spring-projects-issues