Bug #16340: check username attribute when calling user.getName() (instead of checking in constructor) #16546
+10
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jloisel
changed the title
….getName() Signed-off-by: jloisel <[email protected]>
jloisel
force-pushed
the
fix-name-attribute-check
branch
from
ddae9d2 to
e957e39
Compare
spring-projects-issues
added
the
status: waiting-for-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: #16340
When first loaded, the oauth2 user has not the username attribute in his claims. For this reason, checking for the presence of this attribute in the constructor is too early. Once loaded from the userinfo endpoint, the oauth2 user has the username attribute.
I moved the check from constructor to
getName()call to prevent this issue. Junits have been rewritten accordingly.