feat(cloud-stream): search configuration classes for channels and operations #690
Conversation
✅ Deploy Preview for springwolf-ui canceled.
|
| @@ -42,7 +42,7 @@ public class CloudStreamFunctionChannelsScanner implements ChannelsScanner { | |||
|
|
|||
| private final AsyncApiDocketService asyncApiDocketService; | |||
| private final BeanMethodsScanner beanMethodsScanner; | |||
| private final ComponentClassScanner componentClassScanner; | |||
| private final SpringwolfClassScanner classScanner; | |||
There was a problem hiding this comment.
The use of ComponentClassScanner and not SpringwolfClassScanner is intentional.
SpringwolfClassScanner will return classes annotated with @Component which is needed here, but also classes returned by bean methods. In the case of spring cloud stream functions, the bean method always has generics, which can't be retrieved (to my knowledge) from the Class object.
There was a problem hiding this comment.
Agreed. Therefore both scanners are needed.
My intention is to support Configuration annotations as well. And overall to align the cloudstream with the other plugins - if possible.
Will have a closer look, whether Configurations are Components already
| if (Function.class.isAssignableFrom(type)) { | ||
| Class<?> inputType = getTypeGenerics(element).get(0); | ||
| Class<?> outputType = getTypeGenerics(element).get(1); | ||
| if (Function.class.isAssignableFrom(type) && typeGenerics.size() >= 2) { |
There was a problem hiding this comment.
Might be too defensive, Consumer and Supplier always have exactly one generic type and Function always has exactly 2, but that wouldn't hurt.
| @@ -89,8 +90,11 @@ private static String getElementName(AnnotatedElement element) { | |||
|
|
|||
| private List<Class<?>> getTypeGenerics(AnnotatedElement element) { | |||
| if (element instanceof Method m) { | |||
| ParameterizedType genericReturnType = (ParameterizedType) m.getGenericReturnType(); | |||
| return getTypeGenerics(genericReturnType); | |||
| if (m.getGenericReturnType() instanceof ParameterizedType) { | |||
There was a problem hiding this comment.
I did not add the type check because we are always dealing here with methods that return Consumer, Supplier or Function for which getGenericReturnType is always ParameterizedType. But that's probably good practice.
Maybe use smart casting though?
if (m.getGenericReturnType() instanceof ParameterizedType parameterizedType) {
return getTypeGenerics(parameterizedType);
}There was a problem hiding this comment.
I did run into an exception, but could have been an intermediate state.
| @@ -39,15 +39,15 @@ public class CloudStreamFunctionOperationsScanner implements OperationsScanner { | |||
|
|
|||
| private final AsyncApiDocketService asyncApiDocketService; | |||
| private final BeanMethodsScanner beanMethodsScanner; | |||
| private final ComponentClassScanner componentClassScanner; | |||
There was a problem hiding this comment.
Same as first comment, the use of ComponentClassScanner here is intentional.
|
I just checked, |
No description provided.