Isolated public pool + ERC4626 Adapter. #127
Open
+2,631
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpetrunic
previously approved these changes
Nov 3, 2025
contracts/PublicLiquidityPool.sol
Outdated
| uint256 private constant MULTIPLIER = 10000; | ||
| bytes32 private constant FEE_SETTER_ROLE = "FEE_SETTER_ROLE"; | ||
|
|
||
| uint128 private assetsWithLent; |
There was a problem hiding this comment.
Multiplier is the 100% representation. So 200 protocol fee rate will result in 200 / 10000 = 0.02 rate, which is 2%.
assetsWithLent is the amount that should be shared among all depositors. So it is Deposited + Fees - ProtocolFees. I've struggled with the naming, and now I realize it is still bad. Any suggestions? Perhaps virtualAssets.
There was a problem hiding this comment.
or just comment explaining what it is 😂
virtualBalance?
There was a problem hiding this comment.
Renamed and added comment.
viatrix
previously approved these changes
Nov 4, 2025
viatrix
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #122 #123