Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: erc20 contract call tests #274

Merged
merged 10 commits into from
Sep 19, 2024

Conversation

nmlinaric
Copy link
Contributor

Description

unit tests for new erc20 and native token handles optional contract call

Copy link
Collaborator

@mpetrun5 mpetrun5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it looks good.
Just a small nitpick.

test/handlers/erc20/optionalContracCall/executeProposal.js Outdated Show resolved Hide resolved
Copy link
Contributor

@lastperson lastperson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good.
We also need tests for the default message receiver.

@nmlinaric nmlinaric force-pushed the nmlinaric/erc20ContractCall-tests branch from 1693830 to de44494 Compare September 19, 2024 09:04
@lastperson lastperson merged commit 18cb772 into feat/erc20ContractCall Sep 19, 2024
5 checks passed
@nmlinaric nmlinaric deleted the nmlinaric/erc20ContractCall-tests branch September 19, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants