Skip to content
This repository has been archived by the owner on Sep 9, 2024. It is now read-only.

fix duplicate del/inv/rev insertion #150

Merged
merged 1 commit into from
Jul 20, 2023
Merged

Conversation

chunningham
Copy link
Member

@chunningham chunningham commented Jul 19, 2023

Description

re-using a delegation/invocation/revocation should be accepted and not throw an error, except in the case of verification failing or revocation having been applied to a parent. currently kepler will have a conflict in the DB upon insertion of the row into the table. this PR sets such conflicts to not throw an error, but still applies the other verification rules, so re-use of the token will be either a verification error or a no-op.

Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Diligence Checklist

(Please delete options that are not relevant)

  • This change requires a documentation update
  • I have included unit tests
  • I have updated and/or included new integration tests
  • I have updated and/or included new end-to-end tests
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@chunningham chunningham merged commit 5380e33 into main Jul 20, 2023
@chunningham chunningham deleted the fix/double-delegation branch July 20, 2023 09:46
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants