CC-34100 Add Quicksight client adapter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakubanov
reviewed
Aug 1, 2024
| pull_request: | ||
| workflow_dispatch: | ||
|
|
||
| jobs: |
There was a problem hiding this comment.
is it a standard list of validations for eco modules? Don't we need any other ones?
There was a problem hiding this comment.
Tbh, I don't know. I guess, we can clarify this closer to the release phase.
| @@ -0,0 +1,40 @@ | |||
| SPRYKER SYSTEMS GMBH EVALUATION LICENSE AGREEMENT | |||
There was a problem hiding this comment.
Don't we need a special License for eco modules?
There was a problem hiding this comment.
I'll change it to MIT for now, but we'll need to clarify this in the future.
src/SprykerEco/Shared/AmazonQuicksight/AmazonQuicksightConstants.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Shared/AmazonQuicksight/AmazonQuicksightConstants.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Communication/AmazonQuicksightCommunicationFactory.php
Show resolved
Hide resolved
Comment on lines
+16
to
+18
| <foreign-key name="spy_quicksight_user-fk_user" foreignTable="spy_user" phpName="User" refPhpName="QuicksightUser"> | ||
| <reference foreign="id_user" local="fk_user"/> | ||
| </foreign-key> |
There was a problem hiding this comment.
dependency to User module
ilyakubanov
approved these changes
Aug 1, 2024
| */ | ||
| public function getQuicksightUserRegisterNamespace(): string | ||
| { | ||
| return 'default'; |
There was a problem hiding this comment.
Lets move to constant
Comment on lines
+16
to
+18
| <foreign-key name="spy_quicksight_user-fk_user" foreignTable="spy_user" phpName="User" refPhpName="QuicksightUser"> | ||
| <reference foreign="id_user" local="fk_user"/> | ||
| </foreign-key> |
AsonUnique
merged commit 295bc0f
into
feature/cc-34041/dev-quick-sight-mvp
2 checks passed
AsonUnique
deleted the
feature/cc-34041/cc-34100-spryker-quicksight-connection
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview: