Expand user #3
Merged
Expand user #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4041/cc-34137-extend-user-transfer
AsonUnique
reviewed
Aug 5, 2024
| /** | ||
| * Specification: | ||
| * - Iterates over `UserCollectionTransfer.users`. | ||
| * - Requires `UserTransfer.idUser` for each user in collection to be set. |
There was a problem hiding this comment.
The Requires... part usually goes first in the specification.
| * | ||
| * @return list<int> | ||
| */ | ||
| protected function getUserIds(UserCollectionTransfer $userCollectionTransfer): array |
There was a problem hiding this comment.
Suggested change
| protected function getUserIds(UserCollectionTransfer $userCollectionTransfer): array | |
| protected function extractUserIds(UserCollectionTransfer $userCollectionTransfer): array |
| * | ||
| * @return \Generated\Shared\Transfer\UserCollectionTransfer | ||
| */ | ||
| public function expandUserCollectionWithQuicksightUser( |
There was a problem hiding this comment.
Suggested change
| public function expandUserCollectionWithQuicksightUser( | |
| public function expandUserCollectionWithQuicksightUsers( |
| * Use of this software requires acceptance of the Evaluation License Agreement. See LICENSE file. | ||
| */ | ||
|
|
||
| declare(strict_types=1); |
There was a problem hiding this comment.
Please, remove this line
| <property name="role" dataBuilderRule="lexify('??????????')"/> | ||
| <property name="arn" dataBuilderRule="lexify('??????????')"/> | ||
| <property name="principalId" dataBuilderRule="lexify('??????????')"/> | ||
| <property name="uuid" dataBuilderRule="unique()->uuid()"/> |
There was a problem hiding this comment.
We should avoid generating UUIDs in data builders.
AsonUnique
reviewed
Aug 5, 2024
| * @method \SprykerEco\Zed\AmazonQuicksight\Business\AmazonQuicksightFacadeInterface getFacade() | ||
| * @method \SprykerEco\Zed\AmazonQuicksight\Communication\AmazonQuicksightCommunicationFactory getFactory() | ||
| */ | ||
| class QuicksightUserUserExpanderPlugin extends AbstractPlugin implements UserExpanderPluginInterface |
There was a problem hiding this comment.
Maybe we can make an exception from our conventions and name this plugin QuicksightUserExpanderPlugin to avoid duplication in the class name?
ilyakubanov
merged commit a30a781
into
feature/cc-34041/dev-quick-sight-mvp
2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://spryker.atlassian.net/browse/CC-34137