CC-34136 Quicksight user registration and persistence #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilyakubanov
reviewed
Aug 6, 2024
src/SprykerEco/Zed/AmazonQuicksight/Business/Mapper/AmazonQuicksightMapper.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/ApiClient/AmazonQuicksightApiClient.php
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/ApiClient/AmazonQuicksightApiClient.php
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/AmazonQuicksightFacadeInterface.php
Outdated
Show resolved
Hide resolved
| /** | ||
| * Specification: | ||
| * - Expects `UserCollectionResponseTransfer.users.quicksightUser.role` to be set. | ||
| * - Sends request to AWS API to register Quicksight users. For more information see {@link https://docs.aws.amazon.com/quicksight/latest/APIReference/API_RegisterUser.html}. |
There was a problem hiding this comment.
mention that the request is sent for users with roles only
...erEcoTest/Zed/AmazonQuicksight/Business/Facade/CreateQuicksightUsersForUserTransfersTest.php
Outdated
Show resolved
Hide resolved
...erEcoTest/Zed/AmazonQuicksight/Business/Facade/CreateQuicksightUsersForUserTransfersTest.php
Outdated
Show resolved
Hide resolved
src/SprykerEco/Zed/AmazonQuicksight/Business/Creator/QuicksightUserCreator.php
Show resolved
Hide resolved
…4041/cc-34136-persist-qs-user
ilyakubanov
approved these changes
Aug 7, 2024
| use SprykerEco\Zed\AmazonQuicksight\Dependency\External\AmazonQuicksightToAwsQuicksightClientInterface; | ||
| use SprykerEcoTest\Zed\AmazonQuicksight\AmazonQuicksightBusinessTester; | ||
|
|
||
| class CreateQuicksightUsersForUserTransfersTest extends Unit |
There was a problem hiding this comment.
Suggested change
| class CreateQuicksightUsersForUserTransfersTest extends Unit | |
| class CreateQuicksightUsersForUserCollectionResponseTest extends Unit |
AsonUnique
merged commit 20f2e87
into
feature/cc-34041/dev-quick-sight-mvp
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview