Only mock asyncio on request #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would very much appreciate this change: We had literally dozens of failures in our test runs due to the change in behaviour, so I would consider this change here as a bug fix. If one really needs the asyncio stuff, an explicit opt-in looks right. Otherwise pinning to 1.2.2 seems to be the only sane option for us at the moment. 😞 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially reverts #470
Fixes #521
Fixes #522
@marcinsulikowski @boxed As the people that were originally involved with #470 - do you have any problems with this change, to gatekeep this behaviour behind a flag?
The linked issues indicate that this introduced quite some unintended side effects. Hiding this behaviour behind a flag keeps the feature accessible, but also doesn't break everything for others.
I'm torn whether this constitutes a breaking change, or a bugfix. Considering the amount of stuff it seems to break, I may just release it as a new minor version.