PR: Clarify test error message #519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And precompute the delta-time as pytest's: > assert (1728139272.6514266 - 1728139262.6307526) < 5 Is not super useful to know how long the timeout was. In particular it allos us to see in ipykernels' main branch that the delta is >=10s, so that the interrupt call is not properly handled.
ccordoba12
changed the title
ccordoba12
reviewed
Oct 16, 2024
ccordoba12
added
the
type:Task
Co-authored-by: Carlos Cordoba <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And precompute the delta-time as pytest's:
Is not super useful to know how long the timeout was.
In particular it allos us to see in ipykernels' main branch that the delta is >=10s, so that the interrupt call is not properly handled.