Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR: Add logic to handle traceback color configuration #521

Merged
merged 8 commits into from
Nov 26, 2024

Conversation

dalthviz
Copy link
Member

@dalthviz dalthviz self-assigned this Nov 16, 2024
@dalthviz dalthviz changed the title Add logic to handle traceback color configuration [WIP] PR: Add logic to handle traceback color configuration Nov 16, 2024
@dalthviz dalthviz marked this pull request as ready for review November 18, 2024 23:00
@ccordoba12 ccordoba12 added this to the v3.0.2 milestone Nov 19, 2024
@ccordoba12 ccordoba12 added the type:Enhancement New feature or request label Nov 19, 2024
@dalthviz dalthviz changed the title [WIP] PR: Add logic to handle traceback color configuration PR: Add logic to handle traceback color configuration Nov 19, 2024
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dalthviz for this great improvement!

spyder_kernels/console/kernel.py Outdated Show resolved Hide resolved
spyder_kernels/customize/umr.py Outdated Show resolved Hide resolved
spyder_kernels/utils/style.py Show resolved Hide resolved
spyder_kernels/utils/style.py Outdated Show resolved Hide resolved
spyder_kernels/utils/style.py Outdated Show resolved Hide resolved
spyder_kernels/utils/style.py Outdated Show resolved Hide resolved
spyder_kernels/utils/style.py Outdated Show resolved Hide resolved
spyder_kernels/utils/style.py Outdated Show resolved Hide resolved
spyder_kernels/utils/style.py Outdated Show resolved Hide resolved
spyder_kernels/utils/style.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last couple of comments @dalthviz, then this should be ready.

spyder_kernels/customize/code_runner.py Outdated Show resolved Hide resolved
spyder_kernels/customize/umr.py Outdated Show resolved Hide resolved
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, thanks @dalthviz!

@ccordoba12 ccordoba12 merged commit 07f24b6 into spyder-ide:master Nov 26, 2024
12 checks passed
@ccordoba12
Copy link
Member

@meeseeksdev please backport to 3.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:Enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants