PR: Remove a non-ascii file extension from QFileDialog filter #22270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ccordoba12
reviewed
Jul 22, 2024
There was a problem hiding this comment.
Thanks @mrclary for your help with this!
Small question for you, otherwise looks good to me.
ccordoba12
approved these changes
Jul 22, 2024
dalthviz
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Thanks @mrclary ! Gave this a check over my macOS setup and seems like things are working as expected 👍
Left a single comment pointing some info about the non-ascii file extension possible source (mojo language).
Anyhow, this LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
A non-ascii character in the list of file extensions appears to cause issues for the QFileDialog filter on macOS. This may be a bug in PyQt. Nevertheless, removing the offending extension resolves the issue.
Before save as
Before open
After save as
After open
Issue(s) Resolved
Fixes #22248