Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR: Add remote filesystem API to the Remote client plugin #23381

Open
wants to merge 43 commits into
base: master
Choose a base branch
from
Open

PR: Add remote filesystem API to the Remote client plugin #23381

wants to merge 43 commits into from

Conversation

hlouzada
Copy link
Contributor

@hlouzada hlouzada commented Dec 30, 2024 •
edited by ccordoba12
Loading

Description of Changes

  • Wrote at least one-line docstrings (for any new functions)
  • Added unit test(s) covering the changes (if testable)

Use a mixture of rest/websocket to comunicate with spyder-remote-services and provide a filesystem-like API to control remote file system.

This implements the client-side for spyder-ide/spyder-remote-services#11

Affirmation

By submitting this Pull Request or typing my (user)name below,
I affirm the Developer Certificate of Origin
with respect to all commits and content included in this PR,
and understand I am releasing the same under Spyder's MIT (Expat) license.

I certify the above statement is true and correct: @hlouzada

@hlouzada
feat: add fsspek client-side backend for remote files service
9020d1a
@hlouzada
git subrepo pull (merge) external-deps/spyder-kernels
60c68c1 
subrepo:
  subdir:   "external-deps/spyder-kernels"
  merged:   "d7e4319b5"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-kernels.git"
  branch:   "master"
  commit:   "d7e4319b5"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@hlouzada
feat: add fsspec dependency
39a17e3
@pep8speaks
Copy link

pep8speaks commented Dec 30, 2024 •
edited
Loading

Hello @hlouzada! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 115:80: E501 line too long (80 > 79 characters)

Line 2:80: E501 line too long (85 > 79 characters)

Line 28:80: E501 line too long (83 > 79 characters)
Line 36:80: E501 line too long (103 > 79 characters)
Line 394:80: E501 line too long (91 > 79 characters)
Line 427:65: E252 missing whitespace around parameter equals
Line 427:66: E252 missing whitespace around parameter equals

Line 49:80: E501 line too long (100 > 79 characters)
Line 70:80: E501 line too long (86 > 79 characters)
Line 134:80: E501 line too long (88 > 79 characters)
Line 136:80: E501 line too long (86 > 79 characters)
Line 152:80: E501 line too long (81 > 79 characters)

Line 77:17: E231 missing whitespace after ','

Line 65:1: W293 blank line contains whitespace
Line 91:80: E501 line too long (82 > 79 characters)
Line 332:1: W293 blank line contains whitespace

Line 51:80: E501 line too long (85 > 79 characters)

Line 102:80: E501 line too long (85 > 79 characters)
Line 154:1: E305 expected 2 blank lines after class or function definition, found 1

Line 179:80: E501 line too long (80 > 79 characters)

Comment last updated at 2025-01-25 03:08:32 UTC

@hlouzada hlouzada changed the title Add remote-files capability to remote-client plugin [WIP] PR: Add remote-files capability to remote-client plugin Dec 30, 2024
hlouzada added 17 commits January 9, 2025 16:35
@hlouzada
feat: refactor jupyter's rest api for plugin support
737300c
@hlouzada
feat: add rest plugin for spyder remote files api
045c53e
@hlouzada
feat: add custom metaclass for not implemented attributes
6db9945
@hlouzada
fix: also handle oserror on remotefileservices api
7036b08
@hlouzada
feat: inherit FileIO for remote file io api
30efa81
@hlouzada
fix: standarize os methods name and add shutil common functions
f7074bd
@hlouzada
fix: set jupyterpluginbaseapi context as optional
9388da9
@hlouzada
fiix: handle sessions and websockets contexts properly
c021698
@hlouzada
del: remove unused fsspec dependency
afb723b
@hlouzada
refac: move remote plugins as modules and add public api registers
0b26e70
@hlouzada
feat: bump version
dd3223c
@hlouzada
git subrepo pull --branch=feat/remote-file-service --update --force e…
773d4de 
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "8d51ee08a"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "8d51ee08a"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@hlouzada
feat: add support to await dispatched coroutine
be91fca
@hlouzada
fix: don't get attribute value on checking for abstract attributes
8ce21de
@hlouzada
fix: refactor client api and pass manager directly to SpyderBaseJupyt…
38b2581 
…erAPIs
@hlouzada
fix: ensure that the server is connected on remote client base api
55030dd
@hlouzada
feat: add tests for files services
e8c8ef4
@hlouzada hlouzada marked this pull request as ready for review January 18, 2025 13:58
@hlouzada hlouzada changed the title [WIP] PR: Add remote-files capability to remote-client plugin PR: Add remote-files capability to remote-client plugin Jan 18, 2025
@hlouzada
Merge remote-tracking branch 'upstream/master' into add-remoteclient-…
7ec8dc4 
…file-service
@hlouzada
fix: update monkeypatch from refactored client api
167808a
@hlouzada
fix: use AsyncDispatcher to call async tests
d4e60e6
@hlouzada
git subrepo pull --branch=feat/remote-file-service --update --force e…
451733c 
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "e2f920d11"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "e2f920d11"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@hlouzada
git subrepo pull --branch=feat/remote-file-service --update --force e…
f5042ab 
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "83bfb48fd"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "83bfb48fd"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@hlouzada
fix: implement _raise_for_status to SpyderRemoteFileIOAPI
514691e
@hlouzada
fix: add __init__.py to api modules
12b8d84
@hlouzada
fix: use correct endpoint for file services
012f766
@hlouzada
fix: set minimun version back to 1.0.0
1d7a6d2
@hlouzada
git subrepo pull --branch=feat/remote-file-service --update --force e…
646ae16 
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "b77bdbfb2"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "b77bdbfb2"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@ccordoba12 ccordoba12 added this to the v6.1.0 milestone Jan 22, 2025
@ccordoba12 ccordoba12 changed the title PR: Add remote-files capability to remote-client plugin PR: Add remote filesystem API to the Remote client plugin Jan 22, 2025
@hlouzada hlouzada force-pushed the add-remoteclient-file-service branch from 91ae29a to ab22af6 Compare January 23, 2025 13:40
ccordoba12
ccordoba12 reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@ccordoba12 ccordoba12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hlouzada for your hard work to implement this functionality!

spyder/api/asyncdispatcher.py Show resolved Hide resolved
spyder/api/utils.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/api/__init__.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/api/__init__.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/api/__init__.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/tests/test_files.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/tests/test_files.py Show resolved Hide resolved
spyder/plugins/remoteclient/utils/installation.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/widgets/connectiondialog.py Outdated Show resolved Hide resolved
spyder/plugins/remoteclient/widgets/connectionstatus.py Outdated Show resolved Hide resolved
hlouzada and others added 13 commits January 25, 2025 00:05
@hlouzada
refac: apply black to remoteclient
f49c25c
@hlouzada
git subrepo pull --branch=feat/remote-file-service --update --force e…
3ede7e1 
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "4599cda25"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "4599cda25"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@hlouzada
git subrepo pull --branch=feat/remote-file-service --update --force e…
26e2a53 
…xternal-deps/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "bb7624869"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "feat/remote-file-service"
  commit:   "bb7624869"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@hlouzada
git subrepo pull (merge) --branch=main --update --force external-deps…
edd7c94 
…/spyder-remote-services

subrepo:
  subdir:   "external-deps/spyder-remote-services"
  merged:   "2b8dcf2aa"
upstream:
  origin:   "https://github.com/spyder-ide/spyder-remote-services"
  branch:   "main"
  commit:   "2b8dcf2aa"
git-subrepo:
  version:  "0.4.9"
  origin:   "https://github.com/ingydotnet/git-subrepo"
  commit:   "cce3d93"
@hlouzada
refac: fix line length with black
9a649de
@hlouzada
refac: fix pep8
142b263
@hlouzada
fix: test copy file considering random order of ls contents
a9c7a39
@hlouzada @ccordoba12
Apply suggestions from code review
63dfab0 
Co-authored-by: Carlos Cordoba <[email protected]>
@hlouzada
refac: move remoteclient api manager to a separate module
6c09c71
@hlouzada
refac: apply revision comments to manager module
dfbc08d
@hlouzada
refac: add missing docstring, fix typings and update changelog
0e31804
@hlouzada
feat: remove duplicate test and add test for removed dir for complete…
644d468 
…ness
@hlouzada
fix: update signature for SPYDER_REMOTE_MAX_VERSION monkeypatch test
717be57
@hlouzada hlouzada force-pushed the add-remoteclient-file-service branch from 8412b05 to 717be57 Compare January 25, 2025 03:08
@hlouzada hlouzada requested a review from ccordoba12 January 25, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ccordoba12 ccordoba12 Awaiting requested review from ccordoba12

At least 1 approving review is required to merge this pull request.

Assignees

@hlouzada hlouzada

Labels
component:Remote client type:Enhancement
Projects
None yet
Milestone
v6.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hlouzada @pep8speaks @ccordoba12