Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps, pre-commit hooks, & actions, add Prettier and sync w/other repos #217

Merged
merged 12 commits into from
Nov 7, 2023

Conversation

CAM-Gerlach
Copy link
Member

@CAM-Gerlach CAM-Gerlach commented Oct 26, 2023

Counterpart to spyder-ide/spyder-docs#355 and spyder-ide/lektor-icon#22

Regular maintenance PR to update the requirements dependencies, pre-commit hooks and action versions. Additionally, add Prettier to replace the deprecated Stylelint code style rules/fixers, and remove the runtime.txt file setting the Python version for Netlify that was previously required, but no longer is and will avoid an error and the need to manually fix it when Netlify updates its runtime version (as happened for the site theme in spyder-ide/lektor-icon#21 ).

This fixes the csslint issues in #216 by removing this old and unmaintained checker (that is mostly superseded by stylelint). Additionally, I'll re-use most of this to do a similar update to the more out of date scaffolding in the Lektor-Icon theme, to fix spyder-ide/lektor-icon#21 .

This should be ready to go except I need to remove the now-deprecated and warned Stylelint rules and replace them with Prettier, so I've marked it as a draft for the moment to test, and update the site theme with the corresponding changes too (PR pending).

@CAM-Gerlach CAM-Gerlach force-pushed the upgrade-infra-2023-10 branch from 2be7804 to 428620a Compare November 4, 2023 06:24
@CAM-Gerlach CAM-Gerlach changed the title Update deps, pre-commit hooks, & actions, add Prettier and rm old cruft Update deps, pre-commit hooks, & actions, add Prettier and sync w/other repos Nov 4, 2023
@CAM-Gerlach CAM-Gerlach marked this pull request as ready for review November 7, 2023 01:33
@CAM-Gerlach CAM-Gerlach merged commit 46f888c into spyder-ide:master Nov 7, 2023
3 checks passed
@CAM-Gerlach CAM-Gerlach deleted the upgrade-infra-2023-10 branch November 7, 2023 01:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant