Reduce the calling of numbers.size().

sqids · Oct 26, 2023 · 1743e0c · 1743e0c
1 parent d62081e
commit 1743e0c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/main/java/org/sqids/Sqids.java b/src/main/java/org/sqids/Sqids.java
@@ -153,8 +153,9 @@ private String encodeNumbers(final List<Long> numbers, final int increment) {
             throw new RuntimeException("Reached max attempts to re-generate the ID");
         }
 
-        long offset = numbers.size();
-        for (int i = 0; i < numbers.size(); i++) {
+        final int numberSize = numbers.size();
+        long offset = numberSize;
+        for (int i = 0; i < numberSize; i++) {
             offset = offset + this.alphabet.charAt((int) (numbers.get(i) % this.alphabetLength)) + i;
         }
         offset %= this.alphabetLength;
@@ -165,7 +166,6 @@ private String encodeNumbers(final List<Long> numbers, final int increment) {
         final char prefix = alphabetB.charAt(0);
         String alphabet = alphabetB.reverse().toString();
         final StringBuilder id = new StringBuilder().append(prefix);
-        int numberSize = numbers.size();
         for (int i = 0; i < numberSize; i++) {
             final long num = numbers.get(i);
             id.append(toId(num, alphabet.substring(1)));