Expand testing #15
Merged
Expand testing #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reviewing the CI failures now. |
|
CI is failing unrelated to this PR. I've submitted #17 to address the issue. |
kurtmckee
force-pushed
the
expand-testing
branch
from
b33b9ec to
475e3ad
Compare
|
Resolved merge conflicts |
This should resolve a failure in CI caused by Python 3.6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following changes:
Introduce a tox config so the test suite can be run locally against all supported Python versions, with dependencies already installed.
Run the test suite using
tox, ortox pto run everything in parallel.Test against Python 3.12 and 3.13, and update the list of PyPI trove classifiers to indicate support when the next version is released.
Add a test to verify the type of the
min_lengthargument. The code branch was not getting tested at all.Fix an edge case, that developers could pass a bool as the
min_lengthargument.Introduce a coverage config, with a fail-under value of 99% code coverage.
Update CI to use tox, so local and CI testing match.
Use hypothesis to test round-tripping.
Thanks for your work on sqids!