Remove all dependencies #8
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace the derive by exactly the same API, except the derived impl block is merged with the hand-written impl block for the builder type. Remove the docstrings for the private fields of Sqids that were previously used to generate docs for the builder methods, so there is only one place to update when improving the docs for these things. I'm happy to revert this bit if you prefer having the internal docstrings.
A JSON array of strings is valid as a Rust array literal, so parsing the JSON at runtime can be avoided entirely.
|
Gentle ping @4kimov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not a fan of crates like
derive_builderbecause they impose a rather big compile time hit when they are often, like here, only used for a single builder that can easily be written by hand.After having done that, I noticed the other dependencies also did not really seem to pull their weight, so I removed them all 😄
Let me know what you think!