Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chinese doc: install SQLFLow in Kubernetes #3012

Merged
merged 1 commit into from
Oct 15, 2020

Conversation

lhw362950217
Copy link
Collaborator

Related to #3003

@codecov-io
Copy link

codecov-io commented Oct 10, 2020

Codecov Report

Merging #3012 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #3012   +/-   ##
========================================
  Coverage    50.63%   50.63%           
========================================
  Files          247      247           
  Lines        17639    17639           
========================================
  Hits          8932     8932           
  Misses        8026     8026           
  Partials       681      681           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 81bbcd6...6573abf. Read the comment docs.

本文将介绍如何在 Kubernetes 中安装 SQLFlow,你有两种模式可以选择:

* 单人模式:主要针对单个用户,例如在个人电脑上安装。我们采用了相对简化的安装方法,
例如省去了用户登录校验等。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该去掉“单人模式”,部署文档只需要介绍标准,唯一的部署方法。

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里的单人模式指的用Jupyter Notebook作为用户界面的情况,多人模式指的用 JupyterHub,两个都是标准安装方式。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mark TODO。按照新的文档结构,这里需要描述生产环境的部署方式。

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhw362950217 我觉得最好只介绍一个安装流程。只是其中有些 steps 比如 安装JupyterHub 是可选的?

Copy link
Collaborator Author

@lhw362950217 lhw362950217 Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JupyterHub和JupyterNotebook的安装模式和使用场景差异比较大:

多人模式:JupyterHub会负责给每个用户启动一个JupyterNotebook,以及一套数据库资源,同时在一定周期不用就会删掉,适合给较多用户快速体验的场景(如云端Playground)。
单人模式:JupyterNotebook版只是提供了一个UI,没有控制资源的能力,也不会删除资源,用户控制力较强,比较适合用户在本地长期使用。

本文将介绍如何在 Kubernetes 中安装 SQLFlow,你有两种模式可以选择:

* 单人模式:主要针对单个用户,例如在个人电脑上安装。我们采用了相对简化的安装方法,
例如省去了用户登录校验等。
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lhw362950217 我觉得最好只介绍一个安装流程。只是其中有些 steps 比如 安装JupyterHub 是可选的?


集群初始化完成之后,我们可以用如下命令来查看其运行状态, 系统应该回显集群正在运行中:

```bash
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个block里不只是bash命令,而是包括了screenshot。所以应该是 ```text 而不是 bash

```

我们还可以用刚刚安装的 `kubectl` 工具来查看集群的一些细节,例如查看集群中有哪些 namespace。
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我理解 ``` 和之前的文字之间得有一个空行,否则 markdownlinter 会报错吧?


* 单人模式:主要针对单个用户,例如在个人电脑上安装。我们采用了相对简化的安装方法,
例如省去了用户登录校验等。
* 多人模式:主要针对多个用户共享一个 SQLFlow server 的场景,我们增加了用户登录
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我感觉现有一篇文章介绍”多人模式“即可,内容就是标准安装流程。应该是对pc和机群都适合的吧?

@lhw362950217 lhw362950217 merged commit c21dd4e into sql-machine-learning:develop Oct 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants