Allow multiple aggregated columns per query #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This transform doesn't seem to make sense for aggregates other than count, as that is the only one that supports a '*' clause.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: this follows #499 (so some duplicate commits show up), but it doesn't seem possible to set the base branch correctly.
This enables the writing of queries like
SELECT MIN(COLUMN), MAX(COLUMN), SUM(COLUMN) FROM TABLE. The existing behaviour for handling multipleCOUNT()columns is preserved as a special case.Following from #499, this renames the
AsCount()toSelectCount(), which as pointed out in does something different. IfAsCount()should be kept as-is, what would be a good way (name) to make the distinction between what AsCount() does vs. selecting aggregates of columns?