Add accessibilityElements to accessibilityContainer API [UI-6096]
#491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsillik
force-pushed
the
nsillik/a11y-elements
branch
4 times, most recently
from
4f75847
to
19a232d
Compare
nsillik
force-pushed
the
nsillik/a11y-elements
branch
from
19a232d
to
0f5cd21
Compare
kyleve
reviewed
Apr 26, 2024
|
|
||
| /// Creates a new `AccessibilityContainer` wrapping the provided element. | ||
| public init(identifier: String? = nil, wrapping element: Element) { | ||
| public init(identifier: String? = nil, accessibilityElements: [Any]? = nil, wrapping element: Element) { |
There was a problem hiding this comment.
Nit: May be nicer as a result builder?
There was a problem hiding this comment.
This seems reasonable, but a couple questions:
-
When we're using this in practice, what are the a11y elements here exactly? Are they instances of
UIView? Instances ofUIAccessibilityElement? Something else? -
Are these elements that are already in the view / element hierarchy, or are they additions?
There was a problem hiding this comment.
I'm gonna put this on hold for a minute, i think there might be a cleaner way?
meherkasam-square
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes we need to change the inclusion, or order, of accessibility elements inside of accessibility containers. This allows overriding the automatically determined accessibility elements with an explicit list.