include inherited functions in Subcomponent Factory checks #1038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This deprecates `ClassReference.functions` and `ClassReference.properties` in favor of two new properties each. Changes: | old, now deprecated | new | |:---------------------------:|-----------------------------------------------------------------------------------| | `ClassReference.functions` | `ClassReference.memberFunctions` </br> `ClassReference.declaredMemberFunctions` | | `ClassReference.properties` | `ClassReference.memberProperties` </br> `ClassReference.declaredMemberProperties` |
…erence.functions`
JoelWilcox
approved these changes
Jul 20, 2024
| public abstract val declaredMemberProperties: List<MemberPropertyReference> | ||
|
|
||
| /** | ||
| * All properties declared in this class or any of its super-types. |
There was a problem hiding this comment.
Nice, the new api and comments are very clear
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1003
Our checks for a single abstract method in a
@ContributesSubcomponent.Factory-annotated interface do not consider functions that are defined in a supertype. The existingClassReference.functionsproperty was somewhat ambiguously named, which probably contributed to the error.