Update kotlin compile testing to 0.3.1 #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't see how this is gonna work in a dual release setup 🤔 |
What do you mean by this? Are you expecting these changes to have issues on 1.8.22? (So far looks like all the tests passed at least) |
|
The KCT dependency update requires kotlin 1.9.0 and has some breaking changes, so I'm wondering if the 1.8.22 tests are silently getting updated to kotlin 1.9.0 due to the transitive library bump |
|
Hmm interesting, thinking about what we could do to verify that's not happening / ensure something like that never happens even for other changes 🤔. Possibly adding gradle constraints? |
|
Tested in #737 and verified failures, so we should be good for this |
JoelWilcox
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/ZacSweers/kotlin-compile-testing/releases/tag/0.3.1
https://github.com/ZacSweers/kotlin-compile-testing/releases/tag/0.3.0